Skip to content

Comments

rabbitmq-java-client: drop#391100

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
bengsparks:rabbitmq-java-client-py2
Apr 17, 2025
Merged

rabbitmq-java-client: drop#391100
Aleksanaa merged 2 commits intoNixOS:masterfrom
bengsparks:rabbitmq-java-client-py2

Conversation

@bengsparks
Copy link
Contributor

@bengsparks bengsparks commented Mar 18, 2025 •
edited
Loading

Removes yet another dependency on python2 from the tree.
Updates a nixos test that made use of a util program that is no longer being built.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2025
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch from bd91488 to c15d727 Compare March 18, 2025 22:42
@bengsparks bengsparks mentioned this pull request Mar 18, 2025
Closed
2 tasks
@bengsparks
Copy link
Contributor Author

bengsparks commented Mar 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391100

x86_64-linux

✅ 1 package built:
  • rabbitmq-java-client

aarch64-linux

✅ 1 package built:
  • rabbitmq-java-client

x86_64-darwin

✅ 1 package built:
  • rabbitmq-java-client

aarch64-darwin

✅ 1 package built:
  • rabbitmq-java-client

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 18, 2025
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 3 times, most recently from a3e8c63 to 385e119 Compare March 21, 2025 23:19
tomodachi94
tomodachi94 requested changes Mar 22, 2025
View reviewed changes
@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 2 times, most recently from 20ae4c0 to 6bbfebf Compare March 22, 2025 23:51
@tomodachi94
Copy link
Member

tomodachi94 commented Mar 23, 2025

Closes #169644

@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 3 times, most recently from ac1a5b5 to d8c85de Compare March 25, 2025 15:17
@bengsparks bengsparks requested a review from tomodachi94 March 25, 2025 15:21
@bengsparks
Copy link
Contributor Author

bengsparks commented Mar 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391100

x86_64-linux

✅ 1 package built:
  • rabbitmq-java-client

aarch64-linux

✅ 1 package built:
  • rabbitmq-java-client

x86_64-darwin

✅ 1 package built:
  • rabbitmq-java-client

aarch64-darwin

✅ 1 package built:
  • rabbitmq-java-client

@emilazy
Copy link
Member

emilazy commented Mar 29, 2025

As it is unmaintained and so old, perhaps we should simply drop the package?

@bengsparks
Copy link
Contributor Author

bengsparks commented Mar 29, 2025

@emilazy sure, I can do that. Do I need to wait for a specific person's approval or can I just get cracking immediately?

@emilazy
Copy link
Member

emilazy commented Mar 29, 2025

Nobody has touched it outside of treewides since it was added in 2014, and it has no listed maintainer, so I see no reason to wait.

@bengsparks
Copy link
Contributor Author

bengsparks commented Mar 29, 2025 •
edited
Loading

@emilazy

$ nix-build -A rabbitmq-java-client
    error: rabbitmq-java-client has been removed due to its dependency on Python2 and no interest in being maintained within the nixpkgs tree

Now that rabbitmq-java-client will be dropped, I've updated the order of the commits within the PR so that the nixos/rabbitmq module can continue to build regardless of which commit gets checked out.

@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch 2 times, most recently from 745ed20 to 64a26b7 Compare March 29, 2025 16:16
@bengsparks bengsparks changed the title rabbitmq-java-client: 3.3.4 -> 5.25.0, remove python2 dependency rabbitmq-java-client: drop Mar 29, 2025
@github-actions github-actions bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 29, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 29, 2025
tomodachi94
tomodachi94 previously requested changes Mar 29, 2025
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup! Could you add an entry to doc/release-notes/rl-2505.section.md detailing the removal of the package?

Edit: This is non-blocking per #391100 (comment).

@emilazy
Copy link
Member

emilazy commented Mar 29, 2025

I think we can probably skip the changelog entry for something that has been knownVulnerabilities for many years. The throw seems like enough to me.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 4, 2025
@tomodachi94
Copy link
Member

tomodachi94 commented Apr 6, 2025

I think we can probably skip the changelog entry for something that has been knownVulnerabilities for many years. The throw seems like enough to me.

That's fair. I asked for it in this case specifically because it has some out-of-tree usages according to a GitHub search, and was also included in stable NixOS releases for almost a decade.

Ultimately it's up to the PR author if they want to add the entry (the changelog entry is a non-blocking nitpick).

@tomodachi94 tomodachi94 dismissed their stale review April 6, 2025 01:14

non-blocking

@bengsparks
Copy link
Contributor Author

bengsparks commented Apr 6, 2025

Could someone with a Linux machine see if the nixos test passes?
I'm currently away from my raspberry pi, otherwise I'd do it. If not, then I can check in a few days.

@bengsparks bengsparks force-pushed the rabbitmq-java-client-py2 branch from 64a26b7 to 132b709 Compare April 14, 2025 21:23
@bengsparks
Copy link
Contributor Author

bengsparks commented Apr 14, 2025 •
edited
Loading

Got a-hold of my raspberry pi 😄

$ nix-build -A nixosTests.rabbitmq
(finished: waiting for unit rabbitmq.service, in 58.88 seconds)
machine: waiting for success: su -s /nix/store/sff0dw1kwr6vs7y2wghmvigl3ksyp9yj-bash-5.2p37/bin/bash rabbitmq -c "rabbitmqctl status"
machine # [   58.637903] su[1084]: Successful su for rabbitmq by root
machine # [   58.719907] su[1084]: pam_unix(su:session): session opened for user rabbitmq(uid=85) by (uid=0)
machine # [   62.798722] su[1084]: pam_unix(su:session): session closed for user rabbitmq
(finished: waiting for success: su -s /nix/store/sff0dw1kwr6vs7y2wghmvigl3ksyp9yj-bash-5.2p37/bin/bash rabbitmq -c "rabbitmqctl status", in 4.47 seconds)
machine: waiting for TCP port 15672 on localhost
machine # Connection to localhost (127.0.0.1) 15672 port [tcp/*] succeeded!
(finished: waiting for TCP port 15672 on localhost, in 0.17 seconds)
machine: waiting for success: echo Hello World | /nix/store/k9mhkbv4ssb2z3n4ak5xxp0qbasxlvin-amqpcat-1.0.0/bin/amqpcat --producer --uri=amqp://alice:dJT8isYu6t0Xb6u56rPglSj1vK51SlNVlXfwsRxw@localhost --queue test
machine # [   63.130430] rabbitmq-server[831]: 2025-04-14 21:21:11.417525+00:00 [info] <0.709.0> accepting AMQP connection 127.0.0.1:33700 -> 127.0.0.1:5672
machine # [   63.200804] rabbitmq-server[831]: 2025-04-14 21:21:11.487856+00:00 [info] <0.709.0> connection 127.0.0.1:33700 -> 127.0.0.1:5672 has a client-provided name: AMQPCat 1.0.0
machine # [   63.209764] rabbitmq-server[831]: 2025-04-14 21:21:11.494521+00:00 [info] <0.709.0> connection 127.0.0.1:33700 -> 127.0.0.1:5672 - AMQPCat 1.0.0: user 'alice' authenticated and granted access to vhost '/'
machine # [   63.272853] rabbitmq-server[831]: 2025-04-14 21:21:11.559435+00:00 [info] <0.709.0> closing AMQP connection (127.0.0.1:33700 -> 127.0.0.1:5672 - AMQPCat 1.0.0, vhost: '/', user: 'alice', duration: '142ms')
(finished: waiting for success: echo Hello World | /nix/store/k9mhkbv4ssb2z3n4ak5xxp0qbasxlvin-amqpcat-1.0.0/bin/amqpcat --producer --uri=amqp://alice:dJT8isYu6t0Xb6u56rPglSj1vK51SlNVlXfwsRxw@localhost --queue test, in 0.30 seconds)
(finished: run the VM test script, in 64.79 seconds)
test script finished in 65.01

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Apr 15, 2025
@Aleksanaa Aleksanaa merged commit e93827f into NixOS:master Apr 17, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@tomodachi94 tomodachi94 tomodachi94 left review comments

+1 more reviewer

@samueltardieu samueltardieu samueltardieu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bengsparks @tomodachi94 @emilazy @samueltardieu @SuperSandro2000 @wegank @Aleksanaa